Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19602#discussion_r192286696
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -74,23 +86,23 @@ class HiveClientSuite(version: String)
test(s"getPartitionsByFilter returns all partitions when
$tryDirectSqlKey=false") {
val client = init(false)
val filteredPartitions =
client.getPartitionsByFilter(client.getTable("default", "test"),
- Seq(parseExpression("ds=20170101")))
+ Seq(EqualTo(attr("ds"), Literal(20170101, IntegerType))))
--- End diff --
we can import `import org.apache.spark.sql.catalyst.dsl.expressions._` to
simplify expression creation
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
