Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21497#discussion_r193372564
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
 ---
    @@ -256,6 +246,66 @@ class TextSocketStreamSuite extends StreamTest with 
SharedSQLContext with Before
         }
       }
     
    +  test("verify ServerThread only accepts the first connection") {
    +    serverThread = new ServerThread()
    +    serverThread.start()
    +
    +    withSQLConf("spark.sql.streaming.unsupportedOperationCheck" -> 
"false") {
    --- End diff --
    
    Yeah actually I blindly copied the code line in the file. Agreed it would 
be better to use the key.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to