Github user galv commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21494#discussion_r193555968
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -123,6 +124,21 @@ private[spark] class TaskSetManager(
       // TODO: We should kill any running task attempts when the task set 
manager becomes a zombie.
       private[scheduler] var isZombie = false
     
    +  private[scheduler] lazy val barrierCoordinator = {
    --- End diff --
    
    I recommend adding a return type here for readability.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to