Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21511#discussion_r194128417 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -172,7 +184,7 @@ private[spark] class BasicExecutorFeatureStep( .addToImagePullSecrets(kubernetesConf.imagePullSecrets(): _*) .endSpec() .build() - SparkPod(executorPod, containerWithLimitCores) + SparkPod(executorPod, containerWithLimitGpus) --- End diff -- By that logic, it might make sense to make separate steps for varying types of resources. Might be overloading the logic handled by `BasicExecutorStep`. @mccheah for comment
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org