Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21520
For 1, I agree with you that it is not good to introduce many APIs at
first. On the other hand, it would be good to prepare only a few APIs that are
frequently used, not to prepare many APIs. It make code simpler and cleaner.
I think that `inline"${classOf[...].getName}"` and
`inline"${CodeGenerator.javaType(...)}"` are frequently used.
`inline"${CodeGenerator.boxedType(...)}"` may be prepared for consistency with
`inline"${CodeGenerator.javaType(...)}"`.
For 2, new APIs in `ctx` can co-exist with old APIs. Thus, to introduce new
APIs can co-exist with your new proposal.
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
