Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21523#discussion_r194488116 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -91,7 +91,12 @@ private[spark] abstract class WebUI( /** Attach a handler to this UI. */ def attachHandler(handler: ServletContextHandler) { handlers += handler - serverInfo.foreach(_.addHandler(handler)) + serverInfo.foreach { sInfo => + sInfo.addHandler(handler) + // If the UI has already been bound, we need to add the filters to the newly attached + // handlers. Otherwise, they will be attached when binding. + addFilters(Seq(handler), conf) --- End diff -- There's a call to `addFilters` in `HistoryServer.scala` that becomes redundant with this code, I think.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org