Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21529
> I think we need to support both. testing different physical operators
needs same result, testing something like type coercion mode needs different
result. Anyway let's discuss it in the followup.
ok @cloud-fan, I'll try and send a proposal in the next days.
> @mgaido91 Could you help improve the test coverage of joins
org.apache.spark.sql.JoinSuite? Due to the incomplete test case coverage, we
did not discover this at the very beginning. We need to add more test cases to
cover different join algorithms.
Sure, @gatorsmile, I am happy to. Do you mean running the existing tests
for every type of join or do you have something different in mind? Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
