GitHub user fabriziocucci opened a pull request:
https://github.com/apache/spark/pull/21551
Fix issue in 'docker-image-tool.sh'
Because of the missing assignment of the variable `BUILD_ARGS` the command
`./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.0 build` fails:
```
docker build" requires exactly 1 argument.
See 'docker build --help'.
Usage: docker build [OPTIONS] PATH | URL | - [flags]
Build an image from a Dockerfile
```
This has been fixed on the `master` already but, apparently, it has not
been ported back to the branch `2.3`, leading to the same error even on the
latest `2.3.1` release (dated 8 June 2018).
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fabriziocucci/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21551.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21551
----
commit 9e5249653a2b0a43b9a322725392b8309a578235
Author: Fabrizio Cucci <fabrizio.cucci@...>
Date: 2018-06-13T08:48:30Z
Fix issue in 'docker-image-tool.sh'
Because of the missing assignment of the variable `BUILD_ARGS` the command
`./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.0 build` fails:
```
docker build" requires exactly 1 argument.
See 'docker build --help'.
Usage: docker build [OPTIONS] PATH | URL | - [flags]
Build an image from a Dockerfile
```
This has been fixed on the `master` already but, apparently, it has not
been ported back to the branch `2.3`, leading to the same error even on the
latest `2.3.1` release (dated 8 June 2018).
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
