Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21321#discussion_r195344259
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,7 +208,8 @@ class FeatureHasher(@Since("2.3.0") override val uid:
String) extends Transforme
require(dataType.isInstanceOf[NumericType] ||
dataType.isInstanceOf[StringType] ||
dataType.isInstanceOf[BooleanType],
- s"FeatureHasher requires columns to be of NumericType, BooleanType
or StringType. " +
+ s"FeatureHasher requires columns to be of
${NumericType.simpleString}, " +
--- End diff --
I think this PR rewrites always constant type referenced. I am not sure why
you are saying it is not. If I missed some places, then it was just because I
haven't seen them.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
