Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19084#discussion_r195429701
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/MinMaxScaler.scala ---
@@ -117,11 +113,56 @@ class MinMaxScaler @Since("1.5.0") (@Since("1.5.0")
override val uid: String)
@Since("2.0.0")
override def fit(dataset: Dataset[_]): MinMaxScalerModel = {
transformSchema(dataset.schema, logging = true)
- val input: RDD[OldVector] = dataset.select($(inputCol)).rdd.map {
- case Row(v: Vector) => OldVectors.fromML(v)
+
--- End diff --
Rather than copy all that code, I wonder if that utility class can just be
modified to selectively handle NaN differently?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
