Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/21559#discussion_r195268999
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memoryV2.scala
---
@@ -81,22 +84,35 @@ class MemorySinkV2 extends DataSourceV2 with
StreamWriteSupport with MemorySinkB
}.mkString("\n")
}
- def write(batchId: Long, outputMode: OutputMode, newRows: Array[Row]):
Unit = {
+ def write(batchId: Long, outputMode: OutputMode, newRows: Array[Row],
sinkCapacity: Option[Int])
--- End diff --
nit: our style is more like
```scala
def write(
batchId: Long,
outputMode: OutputMode,
newRows: Array[Row],
sinkCapacity: Option[Int]): Unit = {
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
