Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195591438
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -207,9 +400,67 @@ private void assertErrorsContain(Set<String> errors,
Set<String> contains) {
break;
}
}
- assertTrue("Could not find error containing " + contain + "; errors:
" + errors, foundMatch);
+ if (!foundMatch) {
+ notFound.add(contain);
+ }
+ }
+ return new ImmutablePair<>(remainingErrors, notFound);
+ }
+
+ private static class VerifyingStreamCallback implements
StreamCallbackWithID {
+ final String streamId;
+ final StreamSuite.TestCallback helper;
+ final OutputStream out;
+ final File outFile;
+ VerifyingStreamCallback(String streamId) throws IOException {
--- End diff --
nit: add empty line
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
