Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/21572#discussion_r195794051
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -38,10 +38,10 @@ fi
SPARK_K8S_CMD="$1"
--- End diff --
I see two possible pass-through conditions here: one is "empty
SPARK_K8S_CMD" and the other is "SPARK_K8S_CMD is non empty but has non-spark
command in it" Is that the convention, or is the pass-through case always
expected to be "empty SPARK_K8S_CMD" ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
