Github user galv commented on the issue:
https://github.com/apache/spark/pull/20761
I agree that there is apparently unnecessary complexity in the validator.
I'll try to take a look again at the code today.
On Fri, Jun 15, 2018 at 9:15 AM, Marcelo Vanzin <notificati...@github.com>
wrote:
> I don't have issues with the design - I think the main two things I was
> concerned about were:
>
> - not adding another way to set existing Spark options like mem and
> cores, which has been addressed
> - the seemingly unnecessary complexity in certain parts of the code
> like the validator
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/20761#issuecomment-397670091>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AEi_UILXcjEIr37qdC17y73u0W2iz0iUks5t892NgaJpZM4Sg4v9>
> .
>
--
Daniel Galvez
http://danielgalvez.me
https://github.com/galv
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
