Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21552#discussion_r195894982
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -131,6 +132,8 @@ private[sql] class HiveSessionCatalog(
Try(super.lookupFunction(funcName, children)) match {
case Success(expr) => expr
case Failure(error) =>
+ logWarning(s"Encounter a failure during looking up function:" +
+ s" ${Utils.exceptionString(error)}")
if (functionRegistry.functionExists(funcName)) {
--- End diff --
How about `logWarning(s"Failed to look up a function: $funcName")`? I feel
printing `Utils.exceptionString(error)` is a little meaningless.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
