Github user mgaido91 commented on the issue:

    https://github.com/apache/spark/pull/21568
  
    @rxin the PR does what was suggested in these 2 comments 
https://github.com/apache/spark/pull/20023#issuecomment-358306751 and 
https://github.com/apache/spark/pull/21529#issuecomment-396413144. Basically we 
want to run the same SQL test file with different configs.
    
    We have two cases:
     - Running with different configs produces different output (so different 
golden files);
     - Running with different configs produces the same output (so we have only 
one golden file) but the tests are run against different configs.
    
    The goals are to avoid to copy and paste the same queries after setting 
different configurations (as it was done in `decimalArithmeticOperations`) and 
to be able to improve test coverage for the joins (because with default configs 
we basically always execute broadcast joins).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to