Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21598#discussion_r197098227
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1314,6 +1314,13 @@ object SQLConf {
           "Other column values can be ignored during parsing even if they are 
malformed.")
         .booleanConf
         .createWithDefault(true)
    +
    +  val LEGACY_SIZE_OF_NULL = buildConf("spark.sql.legacy.sizeOfNull")
    --- End diff --
    
    Removing is fine. I am good to have such prefix but I wonder what's changed 
after https://github.com/apache/spark/pull/21427#issuecomment-396142545. Sounds 
basically similar to what I suggested. Where did that discussion happen?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to