Github user Fokko commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21596#discussion_r197604577
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
 ---
    @@ -244,6 +244,13 @@ class JsonExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper with
           "1234")
       }
     
    +  test("some big value") {
    +    val value = "x" * 3000
    +    checkEvaluation(
    +      GetJsonObject(NonFoldableLiteral((s"""{"big": "$value"}"""))
    +        , NonFoldableLiteral("$.big")), value)
    --- End diff --
    
    Fixed, much nicer indeed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to