Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20949#discussion_r197644302 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -512,6 +512,43 @@ class CSVSuite extends QueryTest with SharedSQLContext with SQLTestUtils with Te } } + test("Save csv with custom charset") { + Seq("iso-8859-1", "utf-8", "windows-1250").foreach { encoding => + withTempDir { dir => + val csvDir = new File(dir, "csv").getCanonicalPath + // scalastyle:off + val originalDF = Seq("µà áâä ÃÃÃ").toDF("_c0") + // scalastyle:on + originalDF.write + .option("header", "false") --- End diff -- The header flag is disabled by default. Just in case, are there any specific reasons fro testing without CSV header?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org