Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r198043470 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -81,14 +92,14 @@ class JoinOptimizationSuite extends PlanTest { testExtract(x.join(y).join(x.join(z)).where("x.b".attr === "y.d".attr), Some((Seq(x, y, x.join(z)), Seq("x.b".attr === "y.d".attr)))) - testExtractCheckCross(x.join(y, Cross), Some((Seq((x, Cross), (y, Cross)), Seq()))) - testExtractCheckCross(x.join(y, Cross).join(z, Cross), + testExtractInnerJoins(x.join(y, Cross), Some((Seq((x, Cross), (y, Cross)), Seq()))) + testExtractInnerJoins(x.join(y, Cross).join(z, Cross), Some((Seq((x, Cross), (y, Cross), (z, Cross)), Seq()))) - testExtractCheckCross(x.join(y, Cross, Some("x.b".attr === "y.d".attr)).join(z, Cross), + testExtractInnerJoins(x.join(y, Cross, Some("x.b".attr === "y.d".attr)).join(z, Cross), Some((Seq((x, Cross), (y, Cross), (z, Cross)), Seq("x.b".attr === "y.d".attr)))) - testExtractCheckCross(x.join(y, Inner, Some("x.b".attr === "y.d".attr)).join(z, Cross), + testExtractInnerJoins(x.join(y, Inner, Some("x.b".attr === "y.d".attr)).join(z, Cross), Some((Seq((x, Inner), (y, Inner), (z, Cross)), Seq("x.b".attr === "y.d".attr)))) - testExtractCheckCross(x.join(y, Cross, Some("x.b".attr === "y.d".attr)).join(z, Inner), + testExtractInnerJoins(x.join(y, Cross, Some("x.b".attr === "y.d".attr)).join(z, Inner), Some((Seq((x, Cross), (y, Cross), (z, Inner)), Seq("x.b".attr === "y.d".attr)))) } --- End diff -- ok, I'll try to add
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org