Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21635#discussion_r198626433
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
 ---
    @@ -309,6 +312,9 @@ private[spark] class ApplicationMaster(args: 
ApplicationMasterArguments) extends
             finish(FinalApplicationStatus.FAILED,
               ApplicationMaster.EXIT_UNCAUGHT_EXCEPTION,
               "Uncaught exception: " + StringUtils.stringifyException(e))
    +    } finally {
    +      metricsSystem.report()
    --- End diff --
    
    `metricsSystem` can be null at this point, can't it? in case of some issue 
during startup.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to