Github user pgandhi999 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21468#discussion_r198936274
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala 
---
    @@ -811,10 +811,18 @@ private[spark] class Client(
     
         // Finally, update the Spark config to propagate PYTHONPATH to the AM 
and executors.
         if (pythonPath.nonEmpty) {
    -      val pythonPathStr = (sys.env.get("PYTHONPATH") ++ pythonPath)
    +      val pythonPathStr = (sys.env.get("PYTHONPATH") ++=: pythonPath)
             .mkString(ApplicationConstants.CLASS_PATH_SEPARATOR)
    -      env("PYTHONPATH") = pythonPathStr
    -      sparkConf.setExecutorEnv("PYTHONPATH", pythonPathStr)
    +      val newValue =
    --- End diff --
    
    I would have done it, but I need the pythonPathStr variable to set it in 
executorEnv so have not modified that bit. Let me know if you think otherwise.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to