Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21619#discussion_r199105735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -148,14 +149,17 @@ trait Block extends JavaCode {
}
// Concatenates this block with other block.
- def + (other: Block): Block
+ def + (other: Block): Block = other match {
--- End diff --
The ideal usage is that we all put a semantically integral java code into a
`CodeBlock`. If the `CodeBlock` is produced by an expression in codegen, in
order to split it, we should split the entire tree of the `CodeBlock`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
