Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21671#discussion_r199317878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -43,6 +43,11 @@ private[sql] class JacksonGenerator(
// we can directly access data in `ArrayData` without the help of
`SpecificMutableRow`.
private type ValueWriter = (SpecializedGetters, Int) => Unit
+ // A `ValueReader` is responsible for reading a field of an
`InternalRow` to a String.
+ // The only purpose of this is to read the key values for a map so that
they can be
+ // written as JSON filed names.
--- End diff --
filed -> field?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
