Github user pjfanning commented on a diff in the pull request:
https://github.com/apache/spark/pull/21514#discussion_r199344304
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -130,7 +130,13 @@ private[deploy] class Master(
logInfo(s"Running Spark version ${org.apache.spark.SPARK_VERSION}")
webUi = new MasterWebUI(this, webUiPort)
webUi.bind()
- masterWebUiUrl = "http://"; + masterPublicAddress + ":" +
webUi.boundPort
+ val SSL_ENABLED = conf.getBoolean("spark.ssl.enabled", false)
+ val uriScheme = "http://";
+ if (SSL_ENABLED) {
+ uriScheme = "https://";
--- End diff --
Could you try this? It's a bit closer to the usual scala style.
```
val uriScheme = if (conf.getBoolean("spark.ssl.enabled", false))
"https://"; else "http://";
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
