Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21648#discussion_r199379417
--- Diff: python/pyspark/sql/context.py ---
@@ -93,6 +93,11 @@ def _ssql_ctx(self):
"""
return self._jsqlContext
+ @property
+ def _conf(self):
+ """Accessor for the JVM SQL-specific configurations"""
+ return self.sparkSession._jsparkSession.sessionState().conf()
--- End diff --
```
What's the difference between this and SQLContext.getConf ?
```
getConf returns the value of Spark SQL conf for given key and we add this
_conf wants to access the helper methods in SQLConf. Actually this following
the behavior in SQLContext.scala.
https://github.com/apache/spark/blob/3c0c2d09ca89c6b6247137823169db17847dfae3/sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala#L80
```
Can users being confused by two similar APIs?
```
Maybe we should add more comments to explain this? AFAIC its more natural
than get conf in hard code config key.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
