Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21652#discussion_r199608853
  
    --- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
 ---
    @@ -150,6 +179,28 @@ private[spark] class KubernetesSuite extends 
SparkFunSuite
           })
       }
     
    +  test("Run SparkPi with env and mount secrets.") {
    +    sparkAppConf
    +      .set(s"spark.kubernetes.driver.secrets.$ENV_SECRET_NAME", 
SECRET_MOUNT_PATH)
    +      .set(s"spark.kubernetes.driver.secretKeyRef.USERNAME", 
s"$ENV_SECRET_NAME:username")
    +      .set(s"spark.kubernetes.driver.secretKeyRef.PASSWORD", 
s"$ENV_SECRET_NAME:password")
    +      .set(s"spark.kubernetes.executor.secrets.$ENV_SECRET_NAME", 
SECRET_MOUNT_PATH)
    +      .set(s"spark.kubernetes.executor.secretKeyRef.USERNAME", 
s"$ENV_SECRET_NAME:username")
    +      .set(s"spark.kubernetes.executor.secretKeyRef.PASSWORD", 
s"$ENV_SECRET_NAME:password")
    +
    +    runSparkPiAndVerifyCompletion(
    +      driverPodChecker = (driverPod: Pod) => {
    +        doBasicDriverPodCheck(driverPod)
    +          checkSecrets(driverPod)
    --- End diff --
    
    nit: indentation


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to