Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21667#discussion_r199865933
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
 ---
    @@ -148,6 +144,28 @@ class JsonFileFormat extends TextBasedFileFormat with 
DataSourceRegister {
       override def hashCode(): Int = getClass.hashCode()
     
       override def equals(other: Any): Boolean = 
other.isInstanceOf[JsonFileFormat]
    +
    +  override def validateDataType(dataType: DataType, isReadPath: Boolean): 
Unit = dataType match {
    --- End diff --
    
    Then the base class could break other existing file formats, right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to