Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21705#discussion_r199936887
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala 
---
    @@ -66,6 +66,12 @@ object StaticSQLConf {
           .checkValue(cacheSize => cacheSize >= 0, "The maximum size of the 
cache must not be negative")
           .createWithDefault(1000)
     
    +  val CODEGEN_CACHE_SIZE = buildStaticConf("spark.sql.codegen.cacheSize")
    +      .doc("The maximum cache size for generated classes.")
    --- End diff --
    
    We need to explain what is the cache is. It is hard to tell based on this 
description. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to