Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21565#discussion_r200019612
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -488,9 +488,16 @@ private[spark] class ExecutorAllocationManager(
newExecutorTotal = numExistingExecutors
if (testing || executorsRemoved.nonEmpty) {
executorsRemoved.foreach { removedExecutorId =>
+ // If it is cachedBlcok timeout is configured using
+ // spark.dynamicAllocation.cachedExecutorIdleTimeout
+ val idleTimeout = if
(blockManagerMaster.hasCachedBlocks(removedExecutorId)) {
--- End diff --
We do not maintain another HashMap, but alter its original structure. In
this way, we do not need to issue extra rpc calls to `BlockManagerMaster`
here. As you mentioned 'API', this thing happens after a rpc call happened.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
