Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21306#discussion_r200170480
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/catalog/Table.java ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.sources.v2.catalog;
    +
    +import org.apache.spark.sql.catalyst.expressions.Expression;
    +import org.apache.spark.sql.types.StructType;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * Represents table metadata from a {@link DataSourceCatalog}.
    + */
    +public interface Table {
    --- End diff --
    
    This interface is for named tables, not path-based tables. I think that 
would probably be a different interface because not all sources can support 
path-based tables. Cassandra and JDBC are good examples.
    
    For the table metadata, I think we do need partitions. Iceberg creates 
partitioned tables and I'd like to start getting the DDL operations working. 
This is why I proposed this metadata on the SPIP a few months ago. We seem to 
have lazy consensus around it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to