Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21657#discussion_r200197165
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
 ---
    @@ -82,7 +83,12 @@ class UnivocityParser(
       //
       //   output row - ["A", 2]
       private val valueConverters: Array[ValueConverter] = {
    -    schema.map(f => makeConverter(f.name, f.dataType, f.nullable, 
options)).toArray
    +    requiredSchema.map(f => makeConverter(f.name, f.dataType, f.nullable, 
options)).toArray
    +  }
    +
    +  // If `columnPruning` disabled, this index is used to reorder parsed 
tokens
    +  private lazy val tokenIndexArr: Array[Int] = {
    --- End diff --
    
    It seems the code here and in the line 
https://github.com/apache/spark/pull/21657/files#diff-d19881aceddcaa5c60620fdcda99b4c4R51
 above is the same. Could you fold the lines.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to