Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21667#discussion_r200236504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -153,6 +151,16 @@ class CSVFileFormat extends TextBasedFileFormat with
DataSourceRegister {
override def hashCode(): Int = getClass.hashCode()
override def equals(other: Any): Boolean =
other.isInstanceOf[CSVFileFormat]
+
+ override def supportDataType(dataType: DataType, isReadPath: Boolean):
Boolean = dataType match {
+ case BooleanType | ByteType | ShortType | IntegerType | LongType |
FloatType | DoubleType |
+ StringType | BinaryType | DateType | TimestampType | _:
DecimalType => true
--- End diff --
isn't it just `case _: AtomicType => true`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
