Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21667#discussion_r200630376
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
 ---
    @@ -152,6 +152,11 @@ trait FileFormat {
         }
       }
     
    +  /**
    +   * Returns whether this format supports the given [[DataType]] in 
read/write path.
    +   * By default all data types are supported.
    +   */
    +  def supportDataType(dataType: DataType, isReadPath: Boolean): Boolean = 
true
    --- End diff --
    
    I meant to say it's not free to remove or change the signature later once 
we happen to add it. Do we plan to refactor or remove this out in the near 
future? If so I am okay.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to