Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21682#discussion_r201218336
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -60,8 +62,10 @@ private[parquet] class ParquetFilters(pushDownDate: 
Boolean, pushDownStartWith:
       private val makeEq: PartialFunction[ParquetSchemaType, (String, Any) => 
FilterPredicate] = {
         case ParquetBooleanType =>
           (n: String, v: Any) => FilterApi.eq(booleanColumn(n), 
v.asInstanceOf[java.lang.Boolean])
    -    case ParquetIntegerType =>
    -      (n: String, v: Any) => FilterApi.eq(intColumn(n), 
v.asInstanceOf[Integer])
    +    case ParquetByteType | ParquetShortType | ParquetIntegerType =>
    +      (n: String, v: Any) => FilterApi.eq(
    +        intColumn(n),
    +        
Option(v).map(_.asInstanceOf[Number].intValue.asInstanceOf[Integer]).orNull)
    --- End diff --
    
    `makeEq` and `makeNotEq` may be null: 
https://github.com/apache/spark/blob/021145f36432b386cce30450c888a85393d5169f/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala#L241-L242


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to