Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21687#discussion_r201247091
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -685,10 +697,10 @@ object TypeCoercion {
plan: LogicalPlan): LogicalPlan = plan transformAllExpressions {
case e if !e.childrenResolved => e
// Find tightest common type for If, if the true value and false
value have different types.
- case i @ If(pred, left, right) if left.dataType != right.dataType =>
+ case i @ If(pred, left, right) if
!left.dataType.sameType(right.dataType) =>
--- End diff --
Can't we use `areInputTypesForMergingEqual` here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
