Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21635#discussion_r201339532 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -309,6 +312,11 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments) extends finish(FinalApplicationStatus.FAILED, ApplicationMaster.EXIT_UNCAUGHT_EXCEPTION, "Uncaught exception: " + StringUtils.stringifyException(e)) + } finally { + metricsSystem.foreach { ms => + ms.report() --- End diff -- is there any issues with this if AM gets killed badly or OOMs? Basically where we would want to wrap this in try catch and ignore any exceptions from it.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org