Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21721#discussion_r201402523
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/JsonUtils.scala
---
@@ -95,4 +95,25 @@ private object JsonUtils {
}
Serialization.write(result)
}
+
+ /**
+ * Write per-topic partition lag as json string
--- End diff --
I'd suggest handling the custom metrics for Kafka outside the scope of this
PR. Maybe we should have a default maxOffsets, but given that we don't I'm
worried about adding a metric that's misleading in the default case.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
