Github user HeartSaVioR commented on the issue:

    https://github.com/apache/spark/pull/21469
  
    Now I'm thinking about removing "metricProviderLoaderCountOfVersionsInMap" 
and also removing StateStoreCustomAverageMetric, since the value doesn't look 
correct with stream-stream join which handles multiple states in an operation.
    
    We may try out SQLMetric to extend AccumulatorV2[(kind of Metric class), 
(kind of Metric class)] which Metric class can handle merging multiple values 
correctly according to the kind of metric, but this is beyond the scope of PR, 
so just removing "metricProviderLoaderCountOfVersionsInMap" would be clearer 
for this patch for now.
    
    What do you think, @arunmahadevan @jose-torres ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to