Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21741#discussion_r201697107
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -387,6 +389,82 @@ class ParquetFilterSuite extends QueryTest with
ParquetTest with SharedSQLContex
}
}
+ test("filter pushdown - timestamp(TIMESTAMP_MILLIS)") {
--- End diff --
I think we should also test INT96 timestamp type. Also maybe when
`PARQUET_FILTER_PUSHDOWN_TIMESTAMP_ENABLED` is disabled.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
