Github user rdblue commented on the issue:

    https://github.com/apache/spark/pull/21305
  
    I don't think we need (or want) `SaveMode` passed to writers after 
standardizing. Uses of `WriteSupport` will always append data to an existing 
table, which makes it simpler for writers. And it will be used for all writes.
    
    A couple other notes:
    * We will also need a `StagedTable` variant of `DeleteSupport` to support 
`ReplaceData` as an atomic operation, but I want to get the non-atomic variants 
in first; hopefully for 2.4.0.
    * RTAS would use `dropTable` and not `DeleteSupport`, since it is at the 
table level.
    * We may still use `SaveMode` in the DF writer API, which is still under 
discussion.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to