GitHub user dbtsai opened a pull request:

    https://github.com/apache/spark/pull/21749

    [SPARK-24785] [SHELL] Making sure REPL prints Spark UI info and then 
Welcome message

    ## What changes were proposed in this pull request?
    
    After https://github.com/apache/spark/pull/21495 the welcome message is 
printed first, and then Scala prompt will be shown before the Spark UI info is 
printed.
    
    Although it's a minor issue, but visually, it doesn't look as nice as the 
existing behavior. This PR intends to fix it by duplicating the Scala `process` 
code to arrange the printing order. However, one variable is private, so 
reflection has to be used which is not desirable. 
    
    We can use this PR to brainstorm how to handle it properly and how Scala 
can change their APIs to fit our need.
    
    ## How was this patch tested?
    
    Existing test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dbtsai/spark repl-followup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21749
    
----
commit 34ac2897bf1320aad24f7d1a87812335db1e13ca
Author: DB Tsai <d_tsai@...>
Date:   2018-05-29T18:03:40Z

    Upgrade scala to 2.11.12 and 2.12.6
    
    Update LICENSE
    
    Update JLine
    
    update scala-parser-combinators
    
    Error handling
    
    Fix compilation
    
    temp
    
    Revert hack
    
    remove hack

commit d7fc65c1973c33b4cbc0f8a8429cd64024d17ad5
Author: DB Tsai <d_tsai@...>
Date:   2018-06-28T22:45:25Z

    Merge branch 'master' into scala-2.11.12

commit 45c7c5b96eeb47c253f1551bfc780e4b321e25c5
Author: DB Tsai <d_tsai@...>
Date:   2018-06-28T22:46:53Z

    temp

commit e7d02a903438ec5dc3a6151402d1033bcf45c746
Author: DB Tsai <d_tsai@...>
Date:   2018-06-29T00:16:49Z

    update

commit 3f71d20e5ecaacd5dec32beea2da580927697e81
Author: DB Tsai <d_tsai@...>
Date:   2018-07-10T23:01:55Z

    temp

commit fdb084ac38d7b3b2fdccc41fc5854fba003d9015
Author: DB Tsai <d_tsai@...>
Date:   2018-07-10T23:02:36Z

    Merge branch 'master' into repl-followup

commit b1e28e82f0ad9b78e0d03f6cb0f27d7b097f5915
Author: DB Tsai <d_tsai@...>
Date:   2018-07-11T01:14:36Z

    working

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to