Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21733#discussion_r201829938
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -825,6 +825,16 @@ object SQLConf {
         .intConf
         .createWithDefault(100)
     
    +  val ADVANCED_REMOVE_REDUNDANT_IN_STATEFUL_AGGREGATION =
    --- End diff --
    
    I'm sorry, but I'm not sure if I understand your suggestion correctly. I 
guess defining configuration to spark conf would be easier to guard against 
modification after starting query, via existing approach - adding conf to 
OffsetSeqMetadata - whereas I'm not sure we could guard against modification of 
query option. I might be missing something here.
    Could you elaborate a bit more? Thanks in advance!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to