Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r202129753
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/LookupFunctionsSuite.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.analysis
+
+import java.net.URI
+
+import org.apache.spark.sql.catalyst.{FunctionIdentifier, TableIdentifier}
+import org.apache.spark.sql.catalyst.catalog.{CatalogDatabase,
InMemoryCatalog, SessionCatalog}
+import org.apache.spark.sql.catalyst.expressions.Alias
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.catalyst.plans.logical._
+import org.apache.spark.sql.internal.SQLConf
+
+class LookupFunctionsSuite extends PlanTest {
+
+ test("SPARK-23486: the functionExists for the Persistent function
check") {
+ val externalCatalog = new CustomInMemoryCatalog
+ val conf = new SQLConf()
+ val catalog = new SessionCatalog(externalCatalog,
FunctionRegistry.builtin, conf)
+ val analyzer = {
+ catalog.createDatabase(
+ CatalogDatabase("default", "", new URI("loc"), Map.empty),
+ ignoreIfExists = false)
+ new Analyzer(catalog, conf)
+ }
+
+ def table(ref: String): LogicalPlan =
UnresolvedRelation(TableIdentifier(ref))
+ val unresolvedPersistentFunc = UnresolvedFunction("func", Seq.empty,
false)
+ val unresolvedRegisteredFunc = UnresolvedFunction("max", Seq.empty,
false)
+ val plan = Project(
+ Seq(Alias(unresolvedPersistentFunc, "call1")(),
Alias(unresolvedPersistentFunc, "call2")(),
+ Alias(unresolvedPersistentFunc, "call3")(),
Alias(unresolvedRegisteredFunc, "call4")(),
+ Alias(unresolvedRegisteredFunc, "call5")()),
+ table("TaBlE"))
+ analyzer.LookupFunctions.apply(plan)
+ assert(externalCatalog.getFunctionExistsCalledTimes == 1)
+
+ assert(analyzer.LookupFunctions.normalizeFuncName
+ (unresolvedPersistentFunc.name).database == Some("default"))
+ }
+
+ test("SPARK-23486: the functionExists for the Registered function
check") {
+
+ val externalCatalog = new InMemoryCatalog
+ val conf = new SQLConf()
+ val customerFunctionReg = new CustomerFunctionRegistry
+ val catalog = new SessionCatalog(externalCatalog, customerFunctionReg,
conf)
+ val analyzer = {
+ catalog.createDatabase(
+ CatalogDatabase("default", "", new URI("loc"), Map.empty),
+ ignoreIfExists = false)
+ new Analyzer(catalog, conf)
+ }
+
+ def table(ref: String): LogicalPlan =
UnresolvedRelation(TableIdentifier(ref))
+ val unresolvedRegisteredFunc = UnresolvedFunction("max", Seq.empty,
false)
+ val plan = Project(
+ Seq(Alias(unresolvedRegisteredFunc, "call1")(),
Alias(unresolvedRegisteredFunc, "call2")()),
+ table("TaBlE"))
+ analyzer.LookupFunctions.apply(plan)
+ assert(customerFunctionReg.getIsRegisteredFunctionCalledTimes == 2)
+
+ assert(analyzer.LookupFunctions.normalizeFuncName
+ (unresolvedRegisteredFunc.name).database == Some("default"))
+
+ }
+}
+
+class CustomerFunctionRegistry extends SimpleFunctionRegistry {
--- End diff --
@kevinyu98 Instead of extending FunctionRegistry and Catalog, what do think
of extending SessionCatalog and overriding isRegisteredFunction and
isPersistentFunction. So after a invocation of LookupFunction we get a count of
how many times isRegisteredFunction was called and how many times
isPersistentFunction was called ? We can just create an instance of analyzer
with a extended Session catalog that we can use in more than one test ? Would
that be simpler ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
