Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21769#discussion_r202521397
  
    --- Diff: 
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala ---
    @@ -64,7 +64,7 @@ private[avro] class AvroFileFormat extends FileFormat 
with DataSourceRegister {
         // Schema evolution is not supported yet. Here we only pick a single 
random sample file to
         // figure out the schema of the whole dataset.
         val sampleFile =
    -      if 
(conf.getBoolean(AvroFileFormat.IgnoreFilesWithoutExtensionProperty, true)) {
    +      if (AvroFileFormat.ignoreFilesWithoutExtensions(conf)) {
    --- End diff --
    
    I tried running queries. The option 
`avro.mapred.ignore.inputs.without.extension` is not set in `conf`.  This is a 
bug in `spark-avro`.
    Please read the value from `options`. It would be good to have a new test 
case with `avro.mapred.ignore.inputs.without.extension` as true.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to