Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21770#discussion_r202563865
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -1588,6 +1588,15 @@ object CodeGenerator extends Logging {
     
       def primitiveTypeName(dt: DataType): String = 
primitiveTypeName(javaType(dt))
     
    +  def getClassName(cls: Class[_]): String = {
    +    try {
    +      return Option(cls.getCanonicalName).getOrElse(cls.getName)
    +    } catch {
    +      case err: InternalError =>
    --- End diff --
    
    Anyway, `return` removed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to