Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21102#discussion_r202621143
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashSetSuite.scala ---
@@ -73,6 +73,46 @@ class OpenHashSetSuite extends SparkFunSuite with
Matchers {
assert(set.contains(50))
assert(set.contains(999))
assert(!set.contains(10000))
+
+ set.add(1132) // Cause hash contention with 999
+ assert(set.size === 4)
+ assert(set.contains(10))
+ assert(set.contains(50))
+ assert(set.contains(999))
+ assert(set.contains(1132))
+ assert(!set.contains(10000))
+
+ set.remove(1132)
+ assert(set.size === 3)
+ assert(set.contains(10))
+ assert(set.contains(50))
+ assert(set.contains(999))
+ assert(!set.contains(1132))
+ assert(!set.contains(10000))
+
+ set.remove(999)
--- End diff --
What if we remove `999` before `1132`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
