Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21635#discussion_r202886077
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -309,6 +312,16 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments) extends
finish(FinalApplicationStatus.FAILED,
ApplicationMaster.EXIT_UNCAUGHT_EXCEPTION,
"Uncaught exception: " + StringUtils.stringifyException(e))
+ } finally {
+ try {
+ metricsSystem.foreach { ms =>
+ ms.report()
+ ms.stop()
+ }
+ } catch {
+ case e: Exception =>
+ logInfo("Exception during stopping of the metric system: ", e)
--- End diff --
I would suggest to change to warning log if exception occurred.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
