Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21798#discussion_r203160706
  
    --- Diff: 
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala ---
    @@ -276,10 +274,15 @@ private[avro] object AvroFileFormat {
         }
       }
     
    -  def ignoreFilesWithoutExtensions(conf: Configuration): Boolean = {
    -    // Files without .avro extensions are not ignored by default
    -    val defaultValue = false
    +  def ignoreExtension(conf: Configuration, options: Map[String, String]): 
Boolean = {
    --- End diff --
    
    Would you like to see it as a part of this PR or a separate one? I would 
extract some common code like `getBool()` from CSVOptions to a separate trait 
and extend `AvroOptions` by it. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to