Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21700#discussion_r203573819
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
 ---
    @@ -270,11 +273,43 @@ private[state] class HDFSBackedStateStoreProvider 
extends StateStoreProvider wit
         } else Iterator.empty
       }
     
    +  /** This method is intended to be only used for unit test(s). DO NOT 
TOUCH ELEMENTS IN MAP! */
    +  private[state] def getClonedLoadedMaps(): util.SortedMap[Long, MapType] 
= synchronized {
    --- End diff --
    
    just `getLoadedMaps()` is fine. The fact that its cloned is just 
implementation detail.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to